From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Wed, 09 Dec 2009 08:55:01 GMT
Subject: Re: [REROLL PATCH 3/8] Pass unknown protocols to external protocol handlers
Message-ID: <36ca99e90912090055s32d5ebc5p917dd7e528218f68@mail.gmail.com>
In-Reply-To: <7vskbl59ai.fsf@alter.siamese.dyndns.org>

On Wed, Dec 9, 2009 at 00:35, Junio C Hamano <gitster@pobox.com> wrote:
> Ilari Liusvaara <ilari.liusvaara@elisanet.fi> writes:
>> +     } else if (!is_url(url)
>> +             || !prefixcmp(url, "file://")
>> +             || !prefixcmp(url, "git://")
>> +             || !prefixcmp(url, "ssh://")
>> +             || !prefixcmp(url, "git+ssh://")
>> +             || !prefixcmp(url, "ssh+git://")) {
>> +             /* These are builtin smart transports. */
>
> Hmm, what is !is_url(url) at the beginning for, if this lists "builtin"
> smart transports?
I think/hope this should catch theses use cases:

       ?   [user@]host.xz:/path/to/repo.git/
       ?   [user@]host.xz:~user/path/to/repo.git/
       ?   [user@]host.xz:path/to/repo.git