From: Bert Wesarg Date: Tue, 03 Mar 2009 18:05:47 GMT Subject: Re: [PATCH v3] send-email: add --confirm option and configuration setting Message-ID: <36ca99e90903031005g3d54436cs486133a340c1eec1@mail.gmail.com> In-Reply-To: <7vvdqqblij.fsf@gitster.siamese.dyndns.org> On Tue, Mar 3, 2009 at 17:48, Junio C Hamano wrote: > Jay Soffian writes: > >> On Tue, Mar 3, 2009 at 6:54 AM, Bert Wesarg wrote: >>> On Tue, Mar 3, 2009 at 05:52, Jay Soffian wrote: >>>> diff --git a/git-send-email.perl b/git-send-email.perl >>>> index adf7ecb..57127aa 100755 >>>> --- a/git-send-email.perl >>>> +++ b/git-send-email.perl >>>> @@ -837,6 +837,37 @@ X-Mailer: git-send-email $gitversion >>>>        unshift (@sendmail_parameters, >>>>                        '-f', $raw_from) if(defined $envelope_sender); >>>> >>>> +       if ($needs_confirm && !$dry_run) { >>> So, the output is now differnt with and without --dry-run? >> >> There doesn't seem to be any point in having the user confirm before >> sending the message if the message is not actually going to be sent. >> Am I missing something? > > I do not think you are missing anything. > > IIRC, the --dry-run mode shows more clearly to whom you would be CC'ing > the messages; in other words, the behaviour would be different, but it > gives an uninteractive way to confirm, and not pausing for confirmation is > a good thing. > Just to clarify: A user who runs a --dry-run before every sending (like me) would check the Cc list anyway (like me), so he either would have sendmail.confirm=never in the config, so that he will not bothered by send-email while sending or he sees some Cc's that he don't want and can remove them in the sending process. Ok, than I'm fine with this. Regards, Bert