From: Bert Wesarg Date: Mon, 22 Sep 2008 18:10:51 GMT Subject: Re: [TopGit PATCH] tg-patch: add From/Date: line to header and print to file Message-ID: <36ca99e90809221110k2d4be91co8eae665fe4735ed1@mail.gmail.com> In-Reply-To: <20080922153938.GP10360@machine.or.cz> On Mon, Sep 22, 2008 at 17:39, Petr Baudis wrote: > On Fri, Sep 19, 2008 at 11:55:01AM +0200, Bert Wesarg wrote: >> To make this more similar to git format-patch, I added a 'From' and >> a 'Date:' header and let 'tg patch' print to a file (which is shown as output). >> >> Regards >> Bert >> >> Signed-off-by: Bert Wesarg > > I dislike the anyway completely bogus From line. If you want mbox > format, you should call (hypothetical) tg mail. Also, IMHO Date: should > be simply always printed at the end of the header, it's distracting if > it is higher. > > Also, the writing to file is confusing to me. What are you trying to > achieve? If you want to export patches, why not use 'tg export' which > already has this functionality? To me, 'tg patch' is basically > equivalent of 'git show' for the whole branch. You're right. I'm not familiar what is needed as a header to be used with git send-email. But the additional indirection with tg export/git format-patch is overkill for one patch. Therefore I would leave the writing to file, but drop the additional headers for me. Bert > > -- > Petr "Pasky" Baudis