From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Mon, 22 Sep 2008 16:45:54 GMT
Subject: Re: [PATCH 3/3] git abbref-ref: new porcelain for abbreviate_ref()
Message-ID: <36ca99e90809220945s50e30a24v2c88b50982d34274@mail.gmail.com>
In-Reply-To: <7vtzc8xjiv.fsf@gitster.siamese.dyndns.org>

On Mon, Sep 22, 2008 at 17:55, Junio C Hamano <gitster@pobox.com> wrote:
> "Shawn O. Pearce" <spearce@spearce.org> writes:
>
>> Bert Wesarg <bert.wesarg@googlemail.com> wrote:
>>> This gives direct access to the abbreviate_ref() function. The operation
>>> mode defaults to the core.warnambiguousrefs value, like the refname:short
>>> format, but can be explicitly changed with the --{,no}-strict option.
>>>
>>> The bash completion script utilizes this new command.
>>
>> And it slows down too, doesn't it?  Now we are doing a fork per
>> branch during completion.  Yikes.  Didn't you just post a series
>> about making completion faster?
>>
>>> Junio, if this is not a porcelain, tell me.
>>
>> IMHO its plumbing.  Porcelain is used by a human.  Plumbing is the
>> bits needed to make human interfaces.
>
> Shawn is right.
>
> I wouldn't be taking this patch to add a new command, but I suspect that
> this could be an option to rev-parse that is similar to --symbolic.
>
> Teach SHOW_SYMBOLIC_SHORTEST to builtin-rev-parse.c::show_rev(), teach the
> parser cmd_rev_parse() a new option --symbolic-abbrev and you are done,
> right?
>
You are probably right, that this small functionality could fit into
an existing program.
But I haven't look for one.

> By the way, I found it amusing to see Cc: lines _after_ three dashes to
> control send-email --- nice trick I didn't think of ;-)
The only problem is, that git format-patch outputs '---\n'
unconditionally, so I had to remove the second one by hand.

Bert
>
>
>
>