From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Wed, 03 Sep 2008 16:33:45 GMT
Subject: Re: [PATCH v3] for-each-ref: `:short` format for `refname`
Message-ID: <36ca99e90809030933m15ef9cf5p1a56bfe90071fc10@mail.gmail.com>
In-Reply-To: <20080903151829.GB27682@spearce.org>

On Wed, Sep 3, 2008 at 17:18, Shawn O. Pearce <spearce@spearce.org> wrote:
> Bert Wesarg <bert.wesarg@googlemail.com> wrote:
>> Try to shorten the refname to a non-ambiguous name.
>>
>> Changes in v3:
>>  * don't compare sha1's, its ambiguous if the short name
>>    resovles to more than one ref
>>  * use xstrdup()
>>  * use indexes for the loops to clarify backward/forward
>>    direction
>>
>>
>> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
>> Cc: git@vger.kernel.org
>> Cc: szeder@ira.uka.de
>> Cc: Shawn O. Pearce <spearce@spearce.org>
>> ---
>
> Looks good.  But the commit messages shouldn't have the "Changes
> in v3" section or probably the "Cc:" lines.  The changes in v3
> part usually goes below the ---.
Ok, but shouldn't git format-patch detect that there is already a ---
in the commit message, or is it illegal to have more than one ---?

And while we are at it, shouldn't git format-patch detect, that there
is already a [*PATCH*]-prefix in the first line of the commit?

I always need to edit these two things after format-patch.

Bert
>
> --
> Shawn.
>