From: Steffen Prohaska <prohaska@zib.de>
Date: Wed, 06 Aug 2014 04:22:58 GMT
Subject: Re: [PATCH] convert: Stream from fd to required clean filter instead of mmap
Message-ID: <36DA9A8E-2F61-4DD3-9F82-427976C710A6@zib.de>
In-Reply-To: <xmqq4mxsrsao.fsf@gitster.dls.corp.google.com>

I'll address the comments about style in a revised patch.


On Aug 4, 2014, at 9:03 PM, Junio C Hamano <gitster@pobox.com> wrote:

>> +	return apply_filter(path, 0, 0, -1, 0, ca.drv->clean);
> 
> What's the significance of "-1" here?  Does somebody in the
> callchain from apply_filter() check if fd < 0 and act differently
> (not a complaint nor rhetoric question)?

The decision in apply_filter() to return before the real work is
taken on the first 0.  Any value for fd would be ok.  The -1 is
only a reminder that the fd is invalid.

	Steffen