From: Johannes Sixt <j6t@kdbg.org>
Date: Mon, 01 Jul 2019 18:22:46 GMT
Subject: Re: [PATCH] t5319: don't trip over a user name with whitespace
Message-ID: <3645e8cf-3538-7a4e-a54a-f58dc39510e1@kdbg.org>
In-Reply-To: <b1f6a752-6edd-d86c-7d69-7624a2c5407f@gmail.com>

Am 01.07.19 um 14:30 schrieb Derrick Stolee:
> On 7/1/2019 8:11 AM, Johannes Schindelin wrote:
>> Or we stop introducing new Perl calls, and use the perfectly fine
>> `test-tool path-utils file-size` command:
>>
>> https://github.com/git/git/blob/v2.22.0/t/helper/test-path-utils.c#L302-L312
>>
>> This solves not only portability problems but also avoids yet another
>> obstacle into making a `NO_PERL` test suite run really work without Perl.
> Thanks! This does seem like the best option. Thanks for bringing this to our
> attention. Here is a diff, and I'll prepare a full patch:

Thanks. Please also explain why the first of the two tests does not fail
with a large --batch-size (unless it is obvious for people who know a
bit about multi-pack-index, of course).

-- Hannes