From: Adam Roben Date: Wed, 25 Apr 2007 21:03:22 GMT Subject: Re: [PATCH] git-svn: Don't rely on $_ after making a function call Message-ID: <3601FA1C-CDB1-4BFE-93D7-8FF1A79DCF45@apple.com> In-Reply-To: <20070425205948.GA12375@untitled> On Apr 25, 2007, at 1:59 PM, Eric Wong wrote: > Adam Roben wrote: >> Many functions and operators in perl set $_, so its value cannot >> be relied upon >> after calling arbitrary functions. The solution is simply to copy >> the value of >> $_ into a local variable that will not get overwritten. > > Does this fix any particular bug? It looks right to me > and makes the code easier to follow, so; Yes, I was getting warnings that $_ was uninitialized in the eq. Sorry for not mentioning that. -Adam