From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Wed, 24 Jan 2018 18:51:22 GMT
Subject: Re: [PATCH v3 3/3] sequencer: run 'prepare-commit-msg' hook
Message-ID: <3587bc5f-c5f7-d037-6644-25e21a5f4942@ramsayjones.plus.com>
In-Reply-To: <20180124123422.10637-4-phillip.wood@talktalk.net>



On 24/01/18 12:34, Phillip Wood wrote:
> From: Phillip Wood <phillip.wood@dunelm.org.uk>
> 
> Commit 356ee4659b ("sequencer: try to commit without forking 'git
> commit'", 2017-11-24) forgot to run the 'prepare-commit-msg' hook when
> creating the commit. Fix this by writing the commit message to a
> different file and running the hook. Using a different file means that
> if the commit is cancelled the original message file is
> unchanged. Also move the checks for an empty commit so the order
> matches 'git commit'.
> 
> Reported-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
> Reviewed-by: Ramsay Jones <ramsay@ramsayjones.plus.com>

Echoing Eric's earlier email, I don't think this Reviewed-by is
warranted - I only requested the addition of a static keyword,
I didn't actually review the patch.

Thanks.

ATB,
Ramsay Jones