From: Ben Peart <peartben@gmail.com>
Date: Wed, 31 May 2017 00:10:09 GMT
Subject: Re: [PATCH v3 4/6] fsmonitor: add test cases for fsmonitor extension
Message-ID: <35520cf4-6a73-29cb-e058-a0e7e29bfdce@gmail.com>
In-Reply-To: <xmqqa85uas42.fsf@gitster.mtv.corp.google.com>



On 5/30/2017 6:37 PM, Junio C Hamano wrote:
> Ben Peart <peartben@gmail.com> writes:
> 
>> I did a quick search through the existing test scripts and the
>> majority do not link commands together with && when they are in a sub
>> function like this.  I find not having them linked together is easier
>> to write, maintain and is more readable.
> 
> I had an impression that it is true only when the series of commands
> are not about Git.  When testing git commands, we should expect any
> of them to be broken (by somebody else ;-) and prepare to notice it.
> 

Fixed