From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Fri, 24 Apr 2020 00:52:58 GMT
Subject: Re: [PATCH 3/4] graph.c: limit linkage of internal variable
Message-ID: <351abde3-6ae4-dc65-a846-3b45202a07ec@ramsayjones.plus.com>
In-Reply-To: <5bd7b929107c277e10a697bc874b702b85691558.1587648870.git.congdanhqx@gmail.com>



On 23/04/2020 14:47, Đoàn Trần Công Danh wrote:
> Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
> ---
>  graph.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/graph.c b/graph.c
> index 4fb25ad464..4cd9915075 100644
> --- a/graph.c
> +++ b/graph.c
> @@ -1055,7 +1055,7 @@ static void graph_output_commit_line(struct git_graph *graph, struct graph_line
>  		graph_update_state(graph, GRAPH_COLLAPSING);
>  }
>  
> -const char merge_chars[] = {'/', '|', '\\'};
> +static const char merge_chars[] = {'/', '|', '\\'};
>  
>  static void graph_output_post_merge_line(struct git_graph *graph, struct graph_line *line)
>  {
> 

Yep, LGTM.

ATB,
Ramsay Jones