From: Lars Schneider <larsxschneider@gmail.com>
Date: Wed, 10 Aug 2016 19:15:50 GMT
Subject: Re: [PATCH v5 04/15] pkt-line: add packet_write_gently()
Message-ID: <350E338E-BBBA-4FE4-8209-4C05056E2AAD@gmail.com>
In-Reply-To: <xmqq8tw45vtg.fsf@gitster.mtv.corp.google.com>


> On 10 Aug 2016, at 20:21, Junio C Hamano <gitster@pobox.com> wrote:
> 
> Lars Schneider <larsxschneider@gmail.com> writes:
> 
>>> On 10 Aug 2016, at 19:17, Junio C Hamano <gitster@pobox.com> wrote:
>>> 
>> OK. Does this mean I can leave the "packet_write()" to "packet_write_fmt()"
>> rename as is in this series?
> 
> I didn't really check what order you are doing things to answer
> that.
> 
> If the function that is introduced in this step is a version of
> packet_write_fmt() that does its thing only gently, you would want
> to do the rename s/packet_write/packet_write_fmt/ before this step,
> and then add the new function as packet_write_fmt_gently(), I would
> think.

OK - will fix. I did it that way because I thought it would be easier
if we decide to drop the big rename patch.

Thanks,
Lars