From: Paolo Teti <paolo.teti@gmail.com>
Date: Fri, 18 May 2007 11:29:44 GMT
Subject: Re: git-rebase (1.5.0.6) errors
Message-ID: <34a7ae040705180429w454e900cp12426e7164725d45@mail.gmail.com>
In-Reply-To: <86y7jmmmnq.fsf@lola.quinscape.zz>

2007/5/18, David Kastrup <dak@gnu.org>:
> "Paolo Teti" <paolo.teti@gmail.com> writes:
>
> > 2007/5/18, Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>:
> >> Hi,
> >>
> >>
> >> ijjarvin@kivilampi-30:~/work/src/submit$ git-rebase net-2.6.22-origin
> >> First, rewinding head to replay your work on top of it...
> >> HEAD is now at d739437... [IPV4]: Correct rp_filter help text.
> >> fatal: cannot convert from utf-8 to utf-8
> >
> >
> > Now I can't test or try to reproduce your error,
> > but looking at the source code (only with gitweb)
> > I have found another bad use of size_t instead of ssize_t
> > in the reencode_string(..) that take part at the conversion process.
> >
> > Using size_t in the next portion of code the check "count == -1" is
> > never true.
>
> Only if size_t is a larger type than int (could be on x86-64 and alpha
> architectures).  Other than that, this comparison would work.  Which
> does not mean that this does not warrant fixing, but it is not
> necessarily the cause of this problem.

1. Yes this is not necessarily the cause.. I agree.

2. size_t as I know is unsigned and ssize_t is the signed version of
size_t.. so to
    compare with -1 we want ssize_t.