From: René Scharfe <l.s.r@web.de>
Date: Sun, 10 Sep 2017 06:27:30 GMT
Subject: Re: [PATCH 34/34] wt-status: release strbuf after use in wt_longstatus_print_tracking()
Message-ID: <33aecb28-e930-f500-3452-3899d1116d9f@web.de>
In-Reply-To: <xmqqmv6761xk.fsf@gitster.mtv.corp.google.com>

Am 06.09.2017 um 21:51 schrieb Junio C Hamano:
> Rene Scharfe <l.s.r@web.de> writes:
> 
>> If format_tracking_info() returns 0 only if it didn't touch its strbuf
>> parameter, so it's OK to exit early in that case.  Clean up sb in the
>> other case.
> 
> These two "if"s confuse me; perhaps the first one is not needed?

Yes, removing it looks like the best way to make that sentence clearer.
Another would be to replace "only if" with "then".

René