From: Tim Henigan <tim.henigan@gmail.com>
Date: Thu, 25 Feb 2010 18:26:19 GMT
Subject: Re: [RFC/PATCH] notes: rework subcommands and parse options
Message-ID: <32c343771002251026n6d55ea7csbdb4c8899bb5fded@mail.gmail.com>
In-Reply-To: <1267086261-7675-1-git-send-email-bebarino@gmail.com>

On Thu, Feb 25, 2010 at 3:24 AM, Stephen Boyd <bebarino@gmail.com> wrote:
>
> +       else {
> +               result = error("Unknown subcommand: %s", argv[0]);
> +       }

In the case where an unknown subcommand was given, shouldn't the usage
instructions be printed?  i.e. add the following after the error()?

    usage_with_options(git_notes_usage, options);

-Tim