From: Rubén Justo <rjusto@gmail.com>
Date: Fri, 13 Oct 2023 18:25:08 GMT
Subject: Re: [PATCH 2/2] branch.c: adjust error messages to coding guidelines
Message-ID: <329f635f-2050-421e-bd0d-943f8ad0de22@gmail.com>
In-Reply-To: <91e4ad3984147fcc277254a3f6836bf79f5c9550.1697211227.git.gitgitgadget@gmail.com>

On 13-oct-2023 15:33:47, Isoken June Ibizugbe via GitGitGadget wrote:

>  	    replace_each_worktree_head_symref(worktrees, oldref.buf, newref.buf,
>  					      logmsg.buf))
> -		die(_("branch renamed to %s, but HEAD is not updated!"), newname);
> +		die(_("branch renamed to %s, but HEAD is not updated"), newname);

Thanks.  This change is not explicitly suggested in the guidelines, but I think
it fits well in the spirit of this series.

> @@ -965,7 +965,7 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
>  		const char *start_name = argc == 2 ? argv[1] : head;
>  
>  		if (filter.kind != FILTER_REFS_BRANCHES)
> -			die(_("the -a, and -r, options to 'git branch' do not take a branch name\n"
> +			die(_("the -a, and -r, options to 'git branch' do not take a branch name.\n"

You have mistakenly deleted this full stop in the previous [1/2] patch.
Therefore, if you stop doing so, you do not need to add it here.