From: Dan Savilonis Date: Sat, 25 Jul 2009 22:49:34 GMT Subject: Re: git format-patch from date never set Message-ID: <325c62f60907251549o27ebc8f2gcd1d728adb662ffd@mail.gmail.com> In-Reply-To: <81b0412b0907251531u7566813fr10bdd70187e9aca6@mail.gmail.com> On Sat, Jul 25, 2009 at 6:31 PM, Alex Riesen wrote: > Neither. This is not a date, but a part of "loosely defined" mbox format. > In the examples of mbox format I have found, the date in the From: line is generally the same as in the Date: line, albeit in a more ambiguous format. Further, the the git code treats it as a date and attempts to set it. It remains at the default date only because git_committer_info() is called without GIT_COMMITTER_DATE set. So is the code misleading? Was it designed to just meet the minimal requirement of having a date-like string to comform to the mbox format? What's the disadvantage to using the real commit date? -- Dan