From: Avery Pennarun Date: Wed, 25 Nov 2009 23:45:22 GMT Subject: Re: git-subtree: directory mismatch Message-ID: <32541b130911251545x212cc55el9f8d4bc44eadd45b@mail.gmail.com> In-Reply-To: <20091125234122.GA31422@atjola.homenet> 2009/11/25 Björn Steinbrink : > On 2009.11.25 18:20:45 -0500, Avery Pennarun wrote: >> I read the earlier thread and I still don't quite understand this >> point.  What makes it difficult? > > I guess it's -Xfoo vs. -X foo (note the space). Same deal with log > -S. "git log -S foo" would look for an empty string (I guess) > being added/removed in some commit in foo's history, while "git log > -Sfoo" looks for "foo" being added/remove in HEAD's history. Oh. Ouch. Isn't it standard for options-that-take-string-parameters to always *require* that parameter? This seems to be how getopt works. Basically "-X foo" is the same as "-Xfoo" in that system. If parse_options doesn't already do this, should I try to add it somehow? Avery