From: Johannes Schindelin Date: Wed, 31 Aug 2022 20:44:18 GMT Subject: Re: [PATCH v3 0/5] built-in add -p: support diff-so-fancy better Message-ID: <31rnq09n-5nor-22n0-r68n-5o46p313p5p3@tzk.qr> In-Reply-To: <1d4bf456-6fc0-b675-f0ee-f8ce99bd38b2@gmail.com> Hi Phillip, On Tue, 30 Aug 2022, Phillip Wood wrote: > I'm not convinced about patch 1 or about showing the hunk offsets with > interactive.diffFilter in patch 4 but the series looks basically sound. The fourth iteration of this patch series that I just sent out should address both concerns. Thank you! Dscho