From: Marc Branchaud Date: Tue, 20 Jun 2017 18:21:42 GMT Subject: Re: [PATCHv2] Tweak help auto-correct phrasing. Message-ID: <3164ca01-9b54-3c9b-96d8-182c9fbbceb9@xiplink.com> In-Reply-To: <1497981886.28187.6.camel@gmail.com> On 2017-06-20 02:04 PM, Kaartic Sivaraam wrote: > On Tue, 2016-12-20 at 09:02 -0500, Marc Branchaud wrote: >> When auto-correct is enabled, an invalid git command prints a warning >> and >> a continuation message, which differs depending on whether or not >> help.autoCorrect is positive or negative. >> >> With help.autoCorrect = 15: >> >> WARNING: You called a Git command named 'lgo', which does not >> exist. >> Continuing under the assumption that you meant 'log' >> in 1.5 seconds automatically... >> >> With help.autoCorrect < 0: >> >> WARNING: You called a Git command named 'lgo', which does not >> exist. >> Continuing under the assumption that you meant 'log' >> >> The continuation message's phrasing is awkward. This commit cleans >> it up. >> As a bonus, we now use full-sentence strings which make translation >> easier. >> >> With help.autoCorrect = 15: >> >> WARNING: You called a Git command named 'lgo', which does not >> exist. >> Continuing in 1.5 seconds, assuming that you meant 'log'. >> >> With help.autoCorrect < 0: >> >> WARNING: You called a Git command named 'lgo', which does not >> exist. >> Continuing under the assumption that you meant 'log'. >> >> Signed-off-by: Marc Branchaud >> --- >> > Excuse me for bringing this up after a long time. What's the status of > this patch? Was it applied? Looks like it got lost in the shuffle. The topic thread starts at: http://public-inbox.org/git/1482063500.10858.1.camel@gmail.com/ There's no reply to my v2 patch, and I neglected to follow up on it -- sorry! Shall I resend the patch? M.