From: René Scharfe Date: Sat, 02 Jan 2021 15:31:01 GMT Subject: Re: [PATCH 8/8] cache-tree: avoid path comparison loop when silent Message-ID: <30ddf1bd-b315-a399-3016-dcc4f9d7d3b5@web.de> In-Reply-To: <3ed37ae6-1f09-bd6b-c9d9-c8089da1af92@gmail.com> Am 31.12.20 um 17:46 schrieb Derrick Stolee: > To wrap up, I'm going to eject this patch from my v2 since more investigation > must be done to see if this second loop _can_ be dropped. At minimum, it isn't > properly silent when requested and there _is_ a performance boost possible, > even if we keep the check. OK. It *is* suspicious that the test suite doesn't exercise the check done by that second loop. Removing it completely would rob us of so many ways to optimize it, though. ;-) René