From: Glen Choo via GitGitGadget Date: Thu, 31 Mar 2022 18:50:01 GMT Subject: [PATCH v2 4/4] branch: remove negative exit code Message-ID: <306858373ccda2da80fe13fe3113ed793db56e91.1648752601.git.gitgitgadget@gmail.com> In-Reply-To: From: Glen Choo Replace an instance of "exit(-1)" with "exit(1)". We don't use negative exit codes - they are misleading because Unix machines will coerce them to 8-bit unsigned values, losing the sign. Signed-off-by: Glen Choo --- branch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/branch.c b/branch.c index ca7f0c3adf8..581afd634da 100644 --- a/branch.c +++ b/branch.c @@ -263,7 +263,7 @@ static void setup_tracking(const char *new_ref, const char *orig_ref, string_list_append(tracking.srcs, orig_ref); if (install_branch_config_multiple_remotes(config_flags, new_ref, tracking.remote, tracking.srcs) < 0) - exit(-1); + exit(1); cleanup: string_list_clear(&tracking_srcs, 0); -- gitgitgadget