From: Cornelius Weig Date: Thu, 02 Feb 2017 09:16:34 GMT Subject: Re: [PATCH 2/7] completion: add subcommand completion for rerere Message-ID: <303e3381-ad15-c991-afc2-3a55706142f3@tngtech.com> In-Reply-To: <20170202005724.24754-1-szeder.dev@gmail.com> On 02/02/2017 01:57 AM, SZEDER Gábor wrote: > You didn't add 'rerere' to the list of porcelain commands, i.e. it > won't be listed after 'git '. I'm not saying it should be > listed there, because I can't decide whether 'rerere' is considered > porcelain or plumbing... Just wanted to make sure that this omission > was intentional. Yes this is intentional. There is a number of plumbing commands that have command completion, but are not listed in 'git ' (e.g. ls-tree, ls-files, ls-remote, ...). Given that rerere will not be frequently invoked, I would not add it to the porcelain commands.