From: Justin Tobler <jltobler@gmail.com>
Date: Mon, 06 May 2024 21:29:24 GMT
Subject: Re: [PATCH 00/11] reftable: expose write options as config
Message-ID: <2rozmhwf2jpyqmy5vtf2t664ko7ztinbzdmwirrqxspjwzgj7t@jctxour2o73r>
In-Reply-To: <cover.1714630191.git.ps@pks.im>

On 24/05/02 08:51AM, Patrick Steinhardt wrote:
> Hi,
> 
> the reftable format has some flexibility with regards to how exactly it
> writes the respective tables:
> 
>   - The block size allows you to control how large each block is
>     supposed to be. The bigger the block, the more records you can fit
>     into it.
> 
>   - Restart intervals control how often a restart point is written that
>     breaks prefix compression. The lower the interval, the less disk
>     space savings you get.
> 
>   - Object indices can be enabled or disabled. These are optional and
>     Git doesn't use them right now, so disabling them may be a sensible
>     thing to do if you want to save some disk space.
> 
>   - The geometric factor controls when we compact tables during auto
>     compaction.
> 
> This patch series exposes all of these via a new set of configs so that
> they can be tweaked by the user as-needed. It's not expected that those
> are really of much importance for the "normal" user -- the defaults
> should be good enough. But for edge cases (huge repos with millions of
> refs) and for hosting providers these knobs can be helpful.
> 
> This patch series applies on top of d4cc1ec35f (Start the 2.46 cycle,
> 2024-04-30).

I have reviewed these patches and I have nothing to add. Thanks Patrick!

-Justin