From: Jeff Hostetler Date: Tue, 29 Aug 2017 20:08:25 GMT Subject: Re: [RFC 0/7] transitioning to protocol v2 Message-ID: <2ff0ead4-e13a-220e-f858-36ab206c1485@jeffhostetler.com> In-Reply-To: <20170825173550.GJ13924@aiede.mtv.corp.google.com> On 8/25/2017 1:35 PM, Jonathan Nieder wrote: > Hi, > > Jeff King wrote: >> On Thu, Aug 24, 2017 at 03:53:21PM -0700, Brandon Williams wrote: > >>> Another version of Git's wire protocol is a topic that has been discussed and >>> attempted by many in the community over the years. The biggest challenge, as >>> far as I understand, has been coming up with a transition plan to using the new >>> server without breaking existing clients and servers. As such this RFC is >>> really only concerned with solidifying a transition plan. Once it has been >>> decided how we can transition to a new protocol we can get into decided what >>> this new protocol would look like (though it would obviously eliminate the ref >>> advertisement ;). >> > >> I don't think libgit2 implements the server side. That leaves probably >> JGit, Microsoft's VSTS (which I think is custom), and whatever Atlassian >> and GitLab use. > > I'd be happy if someone tests the patches against those. :) I just wanted to jump in here and say I've done some initial testing of this against VSTS and so far it seems fine. And yes, we have a custom git server. VSTS doesn't support the "git://" protocol, so the double-null trick isn't an issue for us. But "https://" worked just fine. I'm still asking around internally whether we support passing SSH environment variables. Jeff