From: Jean-Noël Avila <jn.avila@free.fr>
Date: Tue, 04 Sep 2018 15:13:53 GMT
Subject: Re: [PATCH] i18n: fix dangling dot in die() messages
Message-ID: <2f6f52c8-4b8a-a954-5ffb-5d66dfb97fe1@free.fr>
In-Reply-To: <CACBZZX6Bm-xOO-mvDzmRAA9Xu6HrBr5z+39dp4t6fTTCmNHKbQ@mail.gmail.com>

On 04/09/2018, Ævar Arnfjörð Bjarmason wrote:On Tue, Sep 4, 2018 at 4:59
PM Jean-Noel Avila <jn.avila@free.fr> wrote:
> Your commit message says "dangling dot"...

The dot is dangling on its own line. I don't really catch why this would
be needed.

>
>> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
>> index b56028ba9d..a011abfd7c 100644
>> --- a/builtin/submodule--helper.c
>> +++ b/builtin/submodule--helper.c
>> @@ -521,7 +521,7 @@ static void runcommand_in_submodule_cb(const struct cache_entry *list_item,
>>                 printf(_("Entering '%s'\n"), displaypath);
>>
>>         if (info->argv[0] && run_command(&cp))
>> -               die(_("run_command returned non-zero status for %s\n."),
>> +               die(_("run_command returned non-zero status for %s"),
> ...but here and below you're also removing the newline. Is this
> intended, and does it work as desired afterwards? I.e. were we just
> ignoring the \n?
>

I checked that usually, the die command does not have the final dot nor
a new line. But I'm not sure of what's intended here.