From: David Turner <david.turner@twosigma.com>
Date: Tue, 19 Sep 2017 19:32:44 GMT
Subject: RE: [PATCH v6 10/12] fsmonitor: add test cases for fsmonitor extension
Message-ID: <2f3593f790f5423e853f3bcb0a601ef9@exmbdft7.ad.twosigma.com>
In-Reply-To: <dc1506689d3d4639b56f0489e4219054@exmbdft7.ad.twosigma.com>

I think my comment here might have gotten lost, and I don't want it to because it's something I'm really worried about:

> -----Original Message-----
> From: David Turner
> Sent: Friday, September 15, 2017 6:00 PM
> To: 'Ben Peart' <benpeart@microsoft.com>
> Cc: avarab@gmail.com; christian.couder@gmail.com; git@vger.kernel.org;
> gitster@pobox.com; johannes.schindelin@gmx.de; pclouds@gmail.com;
> peff@peff.net
> Subject: RE: [PATCH v6 10/12] fsmonitor: add test cases for fsmonitor
> extension
> 
> > -----Original Message-----
> > +dirty_repo () {
> > +	: >untracked &&
> > +	: >dir1/untracked &&
> > +	: >dir2/untracked &&
> > +	echo 1 >modified &&
> > +	echo 2 >dir1/modified &&
> > +	echo 3 >dir2/modified &&
> > +	echo 4 >new &&
> > +	echo 5 >dir1/new &&
> > +	echo 6 >dir2/new
> 
> If I add an untracked file named dir3/untracked to dirty_repo  (and
> write_integration_script), then "status doesn't detect unreported
> modifications", below, fails.  Did I do something wrong, or does this turn up a
> bug?