From: Samuel GROOT <samuel.groot@grenoble-inp.org>
Date: Wed, 08 Jun 2016 19:42:08 GMT
Subject: Re: [PATCH v4 4/6] send-email: create email parser subroutine
Message-ID: <2d60a12f-5709-687c-4fc4-b6a0b4719b13@grenoble-inp.org>
In-Reply-To: <xmqqbn3blbpc.fsf@gitster.mtv.corp.google.com>

On 06/08/2016 09:31 PM, Junio C Hamano wrote:
> Samuel GROOT <samuel.groot@grenoble-inp.org> writes:
>
>> I think it's the best way to do it indeed. Furthermore, we did trim
>> CRs and LFs in header fields, but not in the message, making the
>> subroutine inconsistent.
>>
>> Should we rename the subroutine to `parse_header` or leave it as it is?
>
> If it lives inside git-send-email, then parse_header is sufficient
> as everybody would know it is about e-mail without being told.  If
> it is in Git.pm, then parse_email_header would be more appropriate.

It currently lives in Git.pm, following Eric Wong's advice to have a 
more packaged code.