From: Jon Seymour <jon.seymour@gmail.com>
Date: Tue, 05 Jul 2005 09:14:32 GMT
Subject: Re: [PATCH] Fixlet for argument parsing in rev-list.
Message-ID: <2cfc40320507050214154c0fff@mail.gmail.com>
In-Reply-To: <7vpstxg02q.fsf@assigned-by-dhcp.cox.net>

I ack the patch, though --show-breaks could use the same treatment.

jon.

On 7/5/05, Junio C Hamano <junkio@cox.net> wrote:
> The --merge-order flag does not take parameter so there is no
> point doing strncmp with the length.
> 
> Signed-off-by: Junio C Hamano <junkio@cox.net>
> ---
> 
>  rev-list.c |    2 +-
>  1 file changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/rev-list.c b/rev-list.c
> --- a/rev-list.c
> +++ b/rev-list.c
> @@ -462,7 +462,7 @@ int main(int argc, char **argv)
>                         limited = 1;
>                         continue;
>                 }
> -               if (!strncmp(arg, "--merge-order", 13)) {
> +               if (!strcmp(arg, "--merge-order")) {
>                         merge_order = 1;
>                         continue;
>                 }
> ------------------------------------------------
> 
> 


-- 
homepage: http://www.zeta.org.au/~jon/
blog: http://orwelliantremors.blogspot.com/