From: Johannes Sixt Date: Fri, 23 Oct 2015 06:02:51 GMT Subject: [PATCH 1/2 jk/war-on-sprintf] read_branches_file: plug a FILE* leak Message-ID: <2c89c60e470def8f85941933c9fafe4db314628a.1445579874.git.j6t@kdbg.org> The earlier rewrite f28e3ab2 (read_branches_file: simplify string handling) of read_branches_file() lost an fclose() call. Put it back. As on Windows files that are open cannot be removed, the leak manifests in a failure of 'git remote rename origin origin' when the remote's URL is specified in .git/branches/origin, because by the time that the command attempts to remove this file, it is still open. Signed-off-by: Johannes Sixt --- remote.c | 1 + 1 file changed, 1 insertion(+) diff --git a/remote.c b/remote.c index 1101f82..fb16153 100644 --- a/remote.c +++ b/remote.c @@ -282,6 +282,7 @@ static void read_branches_file(struct remote *remote) return; strbuf_getline(&buf, f, '\n'); + fclose(f); strbuf_trim(&buf); if (!buf.len) { strbuf_release(&buf); -- 2.3.2.245.gb5bf9d3