From: Jeff Hostetler <git@jeffhostetler.com>
Date: Fri, 09 Aug 2019 18:17:33 GMT
Subject: Re: [PATCH v3 5/7] quote: add sq_append_quote_argv_pretty()
Message-ID: <2c53b342-f4be-55b0-d14f-16b12826d2a8@jeffhostetler.com>
In-Reply-To: <xmqqtvaqcjhx.fsf@gitster-ct.c.googlers.com>



On 8/9/2019 1:54 PM, Junio C Hamano wrote:
> "Jeff Hostetler via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> +/*
>> + * Legacy function to append each argv value, quoted as necessasry,
>> + * with whitespace before each value.  This results in a leading
>> + * space in the result.
>> + */
>>   void sq_quote_argv_pretty(struct strbuf *dst, const char **argv)
>> +{
>> +	if (argv[0])
>> +		strbuf_addch(dst, ' ');
>> +	sq_append_quote_argv_pretty(dst, argv);
> 
> Micronit (not worth a reroll): if !argv[0], there is no need to call
> append, either.
> 

good catch.  thanks!