From: Jeff Hostetler Date: Tue, 27 Mar 2018 17:14:32 GMT Subject: Re: [PATCH v4] json_writer: new routines to create data in JSON format Message-ID: <2bc6f6a6-bf53-b87c-af02-156ad006a878@jeffhostetler.com> In-Reply-To: On 3/27/2018 11:45 AM, Ramsay Jones wrote: > > > On 27/03/18 04:18, Ramsay Jones wrote: >> On 26/03/18 15:31, git@jeffhostetler.com wrote: >>> From: Jeff Hostetler >>> >> [snip] >> >> Thanks, this version fixes all issues I had (with the compilation >> and sparse warnings). >> >> [Was using UINT64_C(0xffffffffffffffff) a problem on windows?] > > BTW, I forgot to mention that you had some whitespace problems > with this patch, viz: I ran "make sparse" on this and it did not complain about any of this. What command do you run to get these messages? I know they appear as red in diffs (and I usually double check that), but I had not seen a command to complain about them like this. > > $ git log --oneline -1 --check master-json > ab643d838 (master-json) json_writer: new routines to create data in JSON format > t/helper/test-json-writer.c:280: trailing whitespace. > + */ > t/t0019-json-writer.sh:179: indent with spaces. > + "g": 0, > t/t0019-json-writer.sh:180: indent with spaces. > + "h": 1 > $ the leading spaces are required in this case. the pretty json output contains 8 spaces for that sub-structure not a tab. is there a preferred way to denote this in the test script? Jeff