From: Phillip Wood <phillip.wood123@gmail.com>
Date: Mon, 07 Jul 2025 16:42:00 GMT
Subject: Re: [PATCH v2] ssh signing: don't detach the filename strbuf from key_file tempfile
Message-ID: <2ae656ee-cf3e-42a7-815a-016df23ac051@gmail.com>
In-Reply-To: <DB5YM57RVQTT.35ZS2BA5SHY@redoste.xyz>

On 07/07/2025 17:22, redoste wrote:
> On Mon Jul 7, 2025 at 17:26 CEST, Phillip Wood wrote:
>> test_file_is_empty will print a diagnostic message if it fails so it
>> should be clear what has caused the test failure
> Uh, okay, this makes sense and I think it will be clear enough.
> However there is only `test_file_not_empty`, `test_file_is_empty`
> doesn't exist. I will implement it in an other commit.

Sorry I'd misremembered the name, it is "test_must_be_empty"

Phillip
>> The way I see it is that the changes that are being tested are related
>> to commit signing as the invariant that we want to assert is that
>> temporary files are cleaned up after signing commits.
> I see.
> 
> I will update this for a v3.
> Thanks for the feedback!
>