From: Bagas Sanjaya Date: Mon, 15 Nov 2021 05:41:57 GMT Subject: Re: [PATCH] fetch-pack: add TRANSLATORS notice for packfile ready messages Message-ID: <2a4428a5-91d9-a0a5-39cd-eefa1c92024e@gmail.com> In-Reply-To: <211114.86czn3t676.gmgdl@evledraar.gmail.com> On 14/11/21 16.50, Ævar Arnfjörð Bjarmason wrote: > If something isn't meant to be translated do this instead: > > die(_("expected no other sections to be sent after no '%s"), "ready"); > > I.e. pass it as a parameter. > > There can then be a "TRANSLATORS" comment that explains that it's the > string "ready", in reference to that protocol keyword. We do it that way > in various other places, and it completely avoids the potential problem > of a should not be translated string being translated. > Something like: /* TRANSLATORS: The 'ready' string is the protocol keyword. Leave it as is. */ ? But I have admitted that I lean to your suggestion. -- An old man doll... just what I always wanted! - Clara