From: Geert Bosch Date: Fri, 06 Apr 2007 10:35:54 GMT Subject: Re: [PATCH] rename_ref(): only print a warning when config-file update fails Message-ID: <2FE08503-8936-4EB9-9DBF-08AFE2923BD9@gnat.com> In-Reply-To: <11758483861506-git-send-email-hjemli@gmail.com> On Apr 6, 2007, at 04:33, Lars Hjemli wrote: > If git_config_rename_section() fails, rename_ref() used to return > 1, which > left HEAD pointing to an absent refs/heads file (since the actual > renaming > had already occurred). > > Signed-off-by: Lars Hjemli This makes sense in addition to my patch, if the renaming fails for any of the other possible reasons. -Geert