From: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Date: Tue, 20 Jan 2026 23:11:35 GMT
Subject: Re: [PATCH v4 2/2] repo: add new flag --keys to git-repo-info
Message-ID: <2B17A803-F1E0-4A9D-B0B7-2C62DA3939A2@gmail.com>
In-Reply-To: <aW8bOfVLcG58t-Uk@pks.im>


> Tiny nit: we also tend to terminate the last enum value with a comma.
> The reason here is that it makes it easier to add new values going
> forward while only having to change one line.

Sure, I forgot to add it. 

> You also have to adapt `cmd_repo_structure()` to handle this new vaule.
> Otherwise it would `BUG()`. I guess the most reasonable change here
> would be to treat "lines" and "keyvalue" as equivalent?

Nice catch! I don't know if it makes sense. If we change that in
structure, we'll also need to also change in info, making the name
"keyvalue" useless. Another solution: change the current "keyvalues" by
"lines" in those three cases. Maybe it makes more sense than the name
"keyvalue".

> Thanks!

Thanks again, Patrick!