From: Benoit Sigoure Date: Tue, 11 Dec 2007 11:42:11 GMT Subject: Re: [Misfeature] cloning without configuration fails and returns 0 Message-ID: <2A5EA5CA-5A8E-4A9F-9D5C-AAEEFAB1910A@lrde.epita.fr> In-Reply-To: <7vzlwktzzb.fsf@gitster.siamese.dyndns.org> On Dec 9, 2007, at 2:32 AM, Junio C Hamano wrote: > Benoit Sigoure writes: > >> on a new machine I have access to, I fetched tonight's git master >> (git >> version 1.5.3.7.g9758e) and installed it on my account in order to >> clone one of my projects. I did not setup anything in my git config >> and stumbled on the following misfeature: > > This is not a misfeature but an outright bug in an earlier fix to > 13208572fbe8838fd8835548d7502202d1f7b21d (builtin-commit: fix -- > signoff) > > Can you try this and see if it works for you? Yes, thank you. > > -- >8 -- > Re-fix "builtin-commit: fix --signoff" > > An earlier fix to the said commit was incomplete; it mixed up the > meaning of the flag parameter passed to the internal fmt_ident() > function, so this corrects it. > [...] > > Signed-off-by: Junio C Hamano > --- > > builtin-commit-tree.c | 4 ++-- > builtin-commit.c | 4 ++-- > builtin-log.c | 4 ++-- > builtin-tag.c | 4 ++-- > cache.h | 3 +++ > ident.c | 30 ++++++++++++------------------ > refs.c | 2 +- > var.c | 4 ++-- > 8 files changed, 26 insertions(+), 29 deletions(-) -- Benoit Sigoure aka Tsuna EPITA Research and Development Laboratory