From: Hans-Christoph Steiner Date: Mon, 13 Dec 2010 16:28:45 GMT Subject: Re: native-style key bindings for gitk on Mac OS X Message-ID: <29A2F453-C1F8-4C7E-A35B-3F159EB693B8@at.or.at> In-Reply-To: <4D05D998.5080107@op5.se> On Dec 13, 2010, at 3:30 AM, Andreas Ericsson wrote: > On 12/12/2010 11:08 PM, Hans-Christoph Steiner wrote: >> >> Hey all, >> >> This is my first post here, hopefully I'm not doing anything stupid >> ;) I use gitk on Debian, Ubuntu, and Mac OS X. I'm big on having apps >> feel native on each platform. Currently gitk's key bindings are very >> GNU/Linux-ish when using gitk on Mac OS X. I'd like to submit a patch >> to make gitk use native-style key bindings and re-use common key >> bindings. > > So long as the patch lets the original keys work (ie, people who are > used to them as they are now aren't suddenly hit by a nasty surprise), > I think it's a great idea. > >> Before starting this, I just wanted to make sure this isn't some >> hotly debated political issue. >> > > It will be if the old keys stop working or all of a sudden do > something > different. Especially if the new thing it does isn't exactly harmless > but the old thing was. I think that's a good idea. The only problem is Cmd-F5 (i.e. Reload) is already globally claimed in Mac OS X to turn on the accessibility voiceover reader. So all you get is a robot voice reading your GUI to you. This could be Ctrl-F5 instead, then it'd be the same as on GNU/ Linux. .hc ---------------------------------------------------------------------------- "[T]he greatest purveyor of violence in the world today [is] my own government." - Martin Luther King, Jr.