From: Kristoffer Haugsbakk Date: Wed, 03 Jun 2026 18:01:04 GMT Subject: Re: [PATCH v2 3/9] reset: modernize flags passed to `reset_head()` Message-ID: <28af58ac-4299-4510-937d-8326b71422d8@app.fastmail.com> In-Reply-To: <20260603-b4-pks-history-drop-v2-3-742cb5b5176d@pks.im> On Wed, Jun 3, 2026, at 18:14, Patrick Steinhardt wrote: > The flags passed to `reset_head()` are declared as defines. This has > fallen a bit out of practice nowadays, where we instead prefer to use > enums. > > Modernize the code accordingly. > > Signed-off-by: Patrick Steinhardt > --- This seems to refer to this from CodingGuidelines (quoting for reference): When a function `F` accepts flags, those flags should be So this goal makes sense. >[snip]