From: Rubén Justo Date: Sat, 02 Mar 2024 15:50:47 GMT Subject: [PATCH v2 3/5] completion: reflog show Message-ID: <27fe304d-6011-430d-8f43-7e0581566182@gmail.com> In-Reply-To: Let's add completion for in "reflog show" so that the user can easily discover uses like: $ git reflog --since=1.day.ago Signed-off-by: Rubén Justo --- contrib/completion/git-completion.bash | 10 ++++++++++ t/t9902-completion.sh | 5 ++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 849d191b02..dc5f73a9f3 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -2427,6 +2427,16 @@ _git_rebase () _git_reflog () { local subcommands="show delete expire" + local subcommand="$(__git_find_subcommand "$subcommands" "show")" + + case "$subcommand,$cur" in + show,--*) + __gitcomp " + $__git_log_common_options + " + return + ;; + esac __git_complete_refs diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh index dbd57e6a28..04f3620e5b 100755 --- a/t/t9902-completion.sh +++ b/t/t9902-completion.sh @@ -2626,7 +2626,10 @@ test_expect_success 'git reflog show' ' shown Z EOF test_completion "git reflog show sho" "shown " && - test_completion "git reflog shown sho" "shown " + test_completion "git reflog shown sho" "shown " && + test_completion "git reflog --unt" "--until=" && + test_completion "git reflog show --unt" "--until=" && + test_completion "git reflog shown --unt" "--until=" ' test_expect_success 'options with value' ' -- 2.44.0