From: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Date: Wed, 03 Jun 2015 08:25:04 GMT
Subject: Re: [PATCH/RFCv3 2/2] git rebase -i: warn about removed commits
Message-ID: <276406458.54566.1433319904220.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To: <921357851.51732.1433316800782.JavaMail.zimbra@ensimag.grenoble-inp.fr>

> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes: 
> > Ideally, you would check the list of commits displayed too. If the 
> > commits sha1 are stable, this should be easy to do. If it's too hard to 
> > test, I'd say its not worth the trouble, but others may disagree. 
> 
> Originally I chose not to check if the SHA-1 were corrects since 
> check_commits was called right after expand_todo_ids and I thought 
> that expand_todo_ids checked them, but from what I understand, it 
> doesn't seem to check if the SHA-1 are commits, I could be wrong 
> though. 

Ignore this email, I completely misunderstood the email I was
responding to. 
(Mailer that doesn't show the quotes by default) 

Rémi