From: Phillip Wood Date: Mon, 13 Jul 2026 13:17:22 GMT Subject: [PATCH v2 05/10] sequencer: remove unnecessary "or" in pick_one_commit() Message-ID: <26eef6c09586ff2fec42614079189350e137751f.1783948637.git.phillip.wood@dunelm.org.uk> In-Reply-To: From: Phillip Wood If error_with_patch(..., res, ...) succeeds then it returns "res", if it fails then it returns -1. This means that or-ing the return value with "res" is pointless as the result is the same as the return value. Signed-off-by: Phillip Wood --- sequencer.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sequencer.c b/sequencer.c index c97b996bebc..d0d2cc228c8 100644 --- a/sequencer.c +++ b/sequencer.c @@ -5007,9 +5007,8 @@ static int pick_one_commit(struct repository *r, oideq(&opts->squash_onto, &oid)))) to_amend = 1; - return res | error_with_patch(r, item->commit, - arg, item->arg_len, opts, - res, to_amend); + return error_with_patch(r, item->commit, arg, item->arg_len, + opts, res, to_amend); } return res; } -- 2.54.0.200.gfd8d68259e3