From: Derrick Stolee Date: Thu, 24 Jan 2019 17:36:11 GMT Subject: Re: [PATCH v3 6/9] multi-pack-index: implement 'expire' verb Message-ID: <26af4406-1ff8-bb4f-f6fb-5505e2d66df7@gmail.com> In-Reply-To: <20190123221354.136961-1-jonathantanmy@google.com> On 1/23/2019 5:13 PM, Jonathan Tan wrote: > Maybe add a fsck at the end for sanity's sake. Also, I think that > preservation of .keep packfiles is an important feature, and maybe worth > a test. Good points! I forgot to test the .keep stuff directly here because I have an equivalent test in VFS for Git, so my wires got crossed. Thanks, -Stolee