From: Wincent Colaiuta <win@wincent.com>
Date: Fri, 14 Dec 2007 07:47:44 GMT
Subject: Re: [PATCH] Don't use the pager when running "git diff --check"
Message-ID: <26AEA0A9-9F15-4245-9D27-61050DA57E6F@wincent.com>
In-Reply-To: <7vmysdx3la.fsf@gitster.siamese.dyndns.org>

El 14/12/2007, a las 6:11, Junio C Hamano escribió:

> Jeff King <peff@peff.net> writes:
>
>> On Thu, Dec 13, 2007 at 08:45:38PM +0100, Wincent Colaiuta wrote:
>>
>>> In 89d07f75 "git diff" learnt to not run the pager if the user  
>>> passes
>>> the --exit-code switch. This commit does the same for the --check
>>> switch for the same reason: we want the user to get the exit status
>>> from "git diff", not the pager.
>>
>> But --check is also producing useful output, which might need  
>> paged. So
>> you are sacrificing existing interactive use of --check for  
>> scriptable
>> exit-code uses. If you really want the exit code, why not "git diff
>> --check --exit-code"?
>>
>> OTOH, I am not too sad to lose the paging behavior; it would take  
>> quite
>> a few whitespace errors to scroll off the screen.
>
> You are right.  While I do not personally miss paging output, it is a
> regression not to page --check output by default.

I thought this was ok because "git diff --exit-code" also produces  
useful output and also turns off the pager.

> By the way, there is no reason to make --check and --exit-code  
> mutually
> exclusive either.  You could say with --exit-code the command will  
> exit
> with status 01 or'ed in if trees are not identical, and with --check  
> the
> command will exit with status 02 or'ed in.

Yes, this sounds fine to me.

Cheers,
Wincent