From: Torsten Bögershausen Date: Mon, 30 Apr 2018 08:55:50 GMT Subject: Re: [PATCH v1 1/1] test: Correct detection of UTF8_NFD_TO_NFC for APFS Message-ID: <255708be-3cf2-0285-b5e7-4fbc9e0e8ddd@web.de> In-Reply-To: On 30.04.18 09:56, Junio C Hamano wrote: > tboegi@web.de writes: > >> From: Torsten Bögershausen >> >> On HFS (which is the default Mac filesystem prior to High Sierra), >> unicode names are "decomposed" before recording. >> On APFS, which appears to be the new default filesystem in Mac OS High >> Sierra, filenames are recorded as specified by the user. >> >> APFS continues to allow the user to access it via any name >> that normalizes to the same thing. >> >> This difference causes t0050-filesystem.sh to fail two tests. >> >> Improve the test for a NFD/NFC in test-lib.sh: >> Test if the same file can be reached in pre- and decomposed unicode. >> >> Reported-By: Elijah Newren >> Signed-off-by: Torsten Bögershausen >> --- >> t/test-lib.sh | 7 +------ >> 1 file changed, 1 insertion(+), 6 deletions(-) > > Thanks. > > Wouldn't it logically make more sense to check for the target being > an existing file with "-f"? It is not an essential part of the test > for the target to be "readable", but "can be stat(2)ed with the > other UTF-8 representation" is. That make sense. Would you like to amend the patch ?