From: Wincent Colaiuta <win@wincent.com>
Date: Tue, 25 Sep 2007 19:50:34 GMT
Subject: Re: Workflow question
Message-ID: <24DF51B9-1BF9-40C0-A1EF-80EF5072570F@wincent.com>
In-Reply-To: <20070925193416.GB8564@coredump.intra.peff.net>

El 25/9/2007, a las 21:34, Jeff King escribió:

> On Tue, Sep 25, 2007 at 09:09:00PM +0200, Andreas Ericsson wrote:
>
>> We came to the same conclusion at our workplace. Email works  
>> great, but
>> it's faster and better to just walk over to your colleague and ask  
>> what
>> he/she thinks about something.
>
> One of the projects I am working on does things this way, but I  
> have to
> admit that I miss the email code-review process. There are often small
> fixups (stylistic, minor nits, "I would have done it this way...",  
> etc)
> that are worth pointing out at the time, but are more painful to go  
> back
> and correct much later.
>
> And documenting those discussions can really help other developers
> besides the author and reviewer.

Google has a pretty interesting internal code review system:

<http://video.google.com/videoplay?docid=-8502904076440714866>

Cheers,
Wincent