From: David Turner Date: Tue, 18 Apr 2017 17:16:52 GMT Subject: RE: [PATCH] repack: respect gc.pid lock Message-ID: <2400e9cbfaff4838a8f3b23c4c2c5a22@exmbdft7.ad.twosigma.com> In-Reply-To: <20170418034157.oi6hkg5obnca5zsa@sigill.intra.peff.net> > -----Original Message----- > From: Jeff King [mailto:peff@peff.net] > Sent: Monday, April 17, 2017 11:42 PM > To: David Turner > Cc: git@vger.kernel.org; christian.couder@gmail.com; mfick@codeaurora.org; > jacob.keller@gmail.com > Subject: Re: [PATCH] repack: respect gc.pid lock > > On Mon, Apr 17, 2017 at 11:29:18PM +0000, David Turner wrote: > > > We saw this failure in the logs multiple times (with three different > > shas, while a gc was running): > > April 12, 2017 06:45 -> ERROR -> 'git -c repack.writeBitmaps=true repack -A -d > --pack-kept-objects' in [repo] failed: > > fatal: packfile ./objects/pack/pack-[sha].pack cannot be accessed > > Possibly some other repack was also running at the time as well. > > > > My colleague also saw it while manually doing gc (again while repacks > > were likely to be running): > > This is sort of a side question, but...why are you running other repacks alongside > git-gc? It seems like you ought to be doing one or the other. But actually, it would be kind of nice if git would help protect us from doing this?