From: Mikael Magnusson <mikachu@gmail.com>
Date: Sun, 26 Oct 2008 18:29:08 GMT
Subject: Re: Weird problem with long $PATH and alternates (bisected)
Message-ID: <237967ef0810261129y58898019m503a1f1593a95591@mail.gmail.com>
In-Reply-To: <7v63nf5iy1.fsf@gitster.siamese.dyndns.org>

2008/10/26 Junio C Hamano <gitster@pobox.com>:
> René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
>
>> Junio C Hamano schrieb:
>>> "Mikael Magnusson" <mikachu@gmail.com> writes:
>>>
>>>> % mkdir 1; cd 1
>>>> % echo > a; git add a; git commit -m a
>>>> % cd ..
>>>> % git clone -s 1 2
>>>> % git push . master:master
>>>> fatal: Could not switch to
>>>> '/tmp/a/1/.git/objects/n:/usr/games/bin:/usr/local/ipod-chain'
>>>> fatal: The remote end hung up unexpectedly
>>>
>>> I think I see a bug in foreach_alt_odb() to add_refs_from_alternate()
>>> callchain, but I cannot explain why the contents of $PATH leaks to the
>>> error message.
>
> I think the previous patch to sha1_file.c, while it may fix the issue, is
> not quite nice.  Here is a replacement that should work.

It does.

-- 
Mikael Magnusson