From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mon, 06 Feb 2023 20:36:41 GMT
Subject: Re: [PATCH v8 2/3] http: read HTTP WWW-Authenticate response headers
Message-ID: <230206.86bkm65y2c.gmgdl@evledraar.gmail.com>
In-Reply-To: <cd9a02ba94e9eb59b07d0b95140d5b880f122941.1675711789.git.gitgitgadget@gmail.com>


On Mon, Feb 06 2023, Matthew John Cheetham via GitGitGadget wrote:

> From: Matthew John Cheetham <mjcheetham@outlook.com>

> +static inline int skip_iprefix_mem(const char *buf, size_t len,
> +				   const char *prefix,
> +				   const char **out, size_t *outlen)
> +{
> +	size_t prefix_len = strlen(prefix);

Style nit: We typically use \n\n after the end of decls, so an extra
newline here before the code.

> +	if (len < prefix_len)
> +		return 0;
> +
> +	if (!strncasecmp(buf, prefix, prefix_len)){

Style: ")) {", not ")){".