From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Thu, 12 Jan 2023 14:53:07 GMT
Subject: Re: [PATCH 5/6] ls-tree: cleanup the redundant SPACE
Message-ID: <230112.86h6wv248r.gmgdl@evledraar.gmail.com>
In-Reply-To: <20230112091135.20050-6-tenglong.tl@alibaba-inc.com>


On Thu, Jan 12 2023, Teng Long wrote:

> From: Teng Long <dyroneteng@gmail.com>
>
> An redundant space was found in ls-tree.c, which is no doubt
> a small change, but it might be OK to make a commit on its own.

No need to update this series for just this, but if you're doing an
update it would be nice to mention that this minor typo/unwanted syntax
has been there since 61fdbcf98b4 (ls-tree: migrate to parse-options,
2009-11-13).

I.e. to clarify that this is rather ancient, and not some fix-up for a
recent topic (or fixing things earlier in this topic itself).

> Signed-off-by: Teng Long <dyroneteng@gmail.com>
> ---
>  builtin/ls-tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/ls-tree.c b/builtin/ls-tree.c
> index a743959f2b3..72eb70823d5 100644
> --- a/builtin/ls-tree.c
> +++ b/builtin/ls-tree.c
> @@ -14,7 +14,7 @@
>  #include "parse-options.h"
>  #include "pathspec.h"
>  
> -static const  char * const ls_tree_usage[] = {
> +static const char * const ls_tree_usage[] = {
>  	N_("git ls-tree [<options>] <tree-ish> [<path>...]"),
>  	NULL
>  };